fix(linter): false positve in no-unused-vars#10470
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10470 will not alter performanceComparing Summary
|
Dunqing
left a comment
Dunqing
left a comment
There was a problem hiding this comment.
Thanks! I do not fully understand how it works, but from the code, it looks like it can be simplified.
Merge activity
|
graphite-app
bot
force-pushed
the
c/04-17-fix_linter_false_positve_in_no-unused-vars
branch
from
1ef693b to
f0c1eff
Compare
graphite-app
bot
deleted the
c/04-17-fix_linter_false_positve_in_no-unused-vars
branch
know how? rust-lang/rust#138528 looks like so it'd end up (I think) like: match left {
AssignmentTarget::AssignmentTargetIdentifier(id) => {
if id.name == name {
is_used_by_others = false;
} else {
return false; // we can short-circuit
}
}
AssignmentTarget::TSAsExpression(ref TSAsExpression { expression, .. })
| AssignmentTarget::TSSatisfiesExpression(ref TSSatisfiesExpression { expression, .. })
| AssignmentTarget::TSSatisfiesExpression(ref TSSatisfiesExpression { expression, .. })
| AssignmentTarget::TSNonNullExpression(ref TSNonNullExpression { expression, .. })
| AssignmentTarget::TSTypeAssertion(ref TSTypeAssertion { expression, .. })
if expression.is_member_expression() =>
{
return false;
}
|
3 participants
fixes #10458